Minor fixes related to Argo float running#248
Merged
jemrobinson merged 9 commits intomainfrom Apr 9, 2026
Merged
Conversation
jemrobinson
changed the title
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
Contributor
|
Reviewing this |
Member
Author
Contributor
Sophie and I added some comments to that issue about what it would be good to do to test the impact of adding the Argo float data (e.g. testing assumptions about depth / time window, gridding mechanisms etc.). I don't think they need to be done as part of this PR, but if we're going to close #247 we should capture those comments in a new issue about improving the Argo float data. And I would also update the title of #247 to reflect this (e.g. Evaluate impact of current implementation for adding Argo float data) |
jemrobinson
commented
Apr 9, 2026
jemrobinson
changed the title
jemrobinson
changed the title
jemrobinson
force-pushed
the
247-evaluate-argo-float
branch
from
e938eac to
f25a8a2
Compare
Member
Author
|
Merging as set of fixes to Argo source but nothing related to changing defaults. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question
Should we add Argo float data to the default setup?
Testing method
Results
No Argo
With Argo
Persistence